-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: Test remove jinja2 from var_network_filtering_service.var #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6db8696 to
48f03a6
Compare
|
@marcusburghardt Updated. Can you help take a look again. Currently no ubuntu product use |
Great. For more context, every variable has a default value that is used when the variable is not explicitly defined in control files or profiles. In this case, if any rule using this variable is defined in a Ubuntu control file or profile, but the variable is not explicitly defined using the "nftables" option, the rule will use the default (firewalld) and will likely fail. The last version of Ubuntu is also using the STIG control file, which does not include the variable. We should also define the variable Once the PR is opened, we can ask Ubuntu maintainers to review and inform if we also need to set this variable in profiles used by older versions not using control files. |
@marcusburghardt Thanks for your review again. I think you mean add By the way, do you think we should open one PR to remove all Jinja2 from all var file or one PR per var file. |
48f03a6 to
be48ac6
Compare
|
Some kind of var file is more complex, example : https://github.com/ComplianceAsCode/content/blob/master/linux_os/guide/system/accounts/accounts-banners/login_banner_text.var . @marcusburghardt Do you have any suggestions how to remove Jinja2 from this kind var file. |
Description:
Test remove jinja2 from var_network_filtering_service.var
Rationale:
Do it for trestle-bot
Review Hints:
Check all reference of var_network_filtering_service.var