Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes tag formatting across the application by implementing consistent tag sanitization rules. Tags are now normalized to lowercase with spaces replaced by hyphens, and validation ensures they match the pattern /^[a-z0-9-]+$/.
- Adds tag sanitization logic to factories, frontend components, and validation rules
- Moves HTTP request classes from nested namespaces to the main
App\Http\Requestsnamespace - Updates test data to use the new hyphenated tag format
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/RequestFactories/ResourceEdit/StoreResourceEditFactory.php | Adds sanitizeTag method and applies it to all tag arrays in factory |
| tests/Feature/ResourceEditsTest.php | Updates test data to use hyphenated tag format |
| resources/js/Components/Form/TagSelector.vue | Implements frontend tag sanitization with regex validation |
| database/factories/ResourceEditsFactory.php | Updates hardcoded tags to use hyphenated format |
| database/factories/ComputerScienceResourceFactory.php | Adds sanitizeTag method and applies it to all generated tags |
| config/computerScienceResource.php | Adds tags_regex configuration for validation |
| app/Http/Requests/StoreResourceReview.php | Moves from ResourceReview namespace to main Requests namespace |
| app/Http/Requests/StoreResourceRequest.php | Moves namespace and adds regex validation to tag fields |
| app/Http/Requests/StoreResourceEdit.php | Moves namespace and adds regex validation to tag fields |
| app/Http/Requests/StoreCommentRequest.php | Moves from Comment namespace to main Requests namespace |
| app/Http/Controllers/ResourceReviewController.php | Updates import to use new request namespace |
| app/Http/Controllers/ResourceEditsController.php | Updates import to use new request namespace |
| app/Http/Controllers/ComputerScienceResourceController.php | Updates import to use new request namespace |
| app/Http/Controllers/CommentController.php | Updates import to use new request namespace |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tests/RequestFactories/ResourceEdit/StoreResourceEditFactory.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.