Skip to content

Comments

Tags#26

Merged
AllanKoder merged 6 commits intomasterfrom
tags
Aug 19, 2025
Merged

Tags#26
AllanKoder merged 6 commits intomasterfrom
tags

Conversation

@AllanKoder
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings August 19, 2025 00:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes tag formatting across the application by implementing consistent tag sanitization rules. Tags are now normalized to lowercase with spaces replaced by hyphens, and validation ensures they match the pattern /^[a-z0-9-]+$/.

  • Adds tag sanitization logic to factories, frontend components, and validation rules
  • Moves HTTP request classes from nested namespaces to the main App\Http\Requests namespace
  • Updates test data to use the new hyphenated tag format

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/RequestFactories/ResourceEdit/StoreResourceEditFactory.php Adds sanitizeTag method and applies it to all tag arrays in factory
tests/Feature/ResourceEditsTest.php Updates test data to use hyphenated tag format
resources/js/Components/Form/TagSelector.vue Implements frontend tag sanitization with regex validation
database/factories/ResourceEditsFactory.php Updates hardcoded tags to use hyphenated format
database/factories/ComputerScienceResourceFactory.php Adds sanitizeTag method and applies it to all generated tags
config/computerScienceResource.php Adds tags_regex configuration for validation
app/Http/Requests/StoreResourceReview.php Moves from ResourceReview namespace to main Requests namespace
app/Http/Requests/StoreResourceRequest.php Moves namespace and adds regex validation to tag fields
app/Http/Requests/StoreResourceEdit.php Moves namespace and adds regex validation to tag fields
app/Http/Requests/StoreCommentRequest.php Moves from Comment namespace to main Requests namespace
app/Http/Controllers/ResourceReviewController.php Updates import to use new request namespace
app/Http/Controllers/ResourceEditsController.php Updates import to use new request namespace
app/Http/Controllers/ComputerScienceResourceController.php Updates import to use new request namespace
app/Http/Controllers/CommentController.php Updates import to use new request namespace

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

AllanKoder and others added 4 commits August 18, 2025 17:52
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@AllanKoder AllanKoder merged commit 21ab4ed into master Aug 19, 2025
1 check passed
@AllanKoder AllanKoder deleted the tags branch August 19, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant