Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements several quality of life improvements across the application, focusing on UI enhancements and deployment optimizations. The changes improve user experience with better textarea sizing and text formatting, while also adding deployment cache optimization.
- Increased textarea rows from 3/6 to 8 for better description editing experience
- Added whitespace preservation for resource descriptions to maintain formatting
- Added cache optimization to deployment process with new Envoy task
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| resources/js/Pages/Resources/Form/MandatoryFields.vue | Increased textarea rows from 3 to 8 for resource description input |
| resources/js/Pages/ResourceEdits/Create.vue | Increased textarea rows from 6 to 8 for consistent description editing |
| resources/js/Components/Resources/ResourceDescription.vue | Added whitespace-pre-line class to preserve line breaks in descriptions |
| config/filesystems.php | Added TODO comment for switching to production filesystem driver |
| Envoy.blade.php | Added optimize-cache task to deployment process for cache management |
| .env.example | Added FILESYSTEM_PUBLIC_DRIVER environment variable example |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| 'throw' => false, | ||
| ], | ||
|
|
||
| // TODO: SWITCH TO JUST PRODUCTION INSTEAD |
There was a problem hiding this comment.
The TODO comment is vague and doesn't provide sufficient context. Consider adding more specific details about what should be switched to production and when this change should be made.
Suggested change
| // TODO: SWITCH TO JUST PRODUCTION INSTEAD | |
| // In production, ensure 'public' disk uses S3 by setting FILESYSTEM_PUBLIC_DRIVER to 's3' in the environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.