Skip to content

Comments

Resource Deletion#34

Merged
AllanKoder merged 8 commits intomasterfrom
More-edits
Aug 29, 2025
Merged

Resource Deletion#34
AllanKoder merged 8 commits intomasterfrom
More-edits

Conversation

@AllanKoder
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings August 29, 2025 18:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements resource deletion functionality for Computer Science Resources, adding soft delete capabilities and cleanup operations for associated data.

  • Adds soft delete functionality to Computer Science Resources with proper cleanup observers
  • Updates resource editing tests to verify image deletion behavior during merges
  • Refactors form validation in Vue component from PrimeVue resolver to manual Yup validation

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
database/migrations/2025_08_29_170217_add_soft_delete_and_indexing_to_computer_science_resources.php Adds soft delete column and page_url index to resources table
app/Models/ComputerScienceResource.php Enables soft deletes and defines cascade delete relationships
app/Observers/ComputerScienceResourceObserver.php Implements cleanup logic for tags and images during deletion
app/Observers/ResourceReviewObserver.php Changes event from 'deleted' to 'deleting' for proper timing
app/Listeners/UpdateResourceReviewSummary.php Fixes property name and adds deletion handling for review summaries
app/Events/ResourceReviewProcessed.php Renames property from 'resource' to 'resource_id' for clarity
app/Http/Controllers/ResourceEditsController.php Adds immediate old image deletion during resource edits merge
app/Services/ComputerScienceResourceService.php Simplifies duplicate detection to use only page_url
app/Filament/Admin/Resources/ComputerScienceResource.php Changes delete action to use forceDelete instead of soft delete
tests/Feature/ResourceEditsTest.php Updates tests to verify image deletion behavior and renames test method
tests/Feature/ComputerScienceResourceTest.php Adds comprehensive cleanup test and updates existing deletion test
tests/Feature/CommentsTest.php Renames test method for consistency
resources/js/Components/Resources/Reviews/CreateResourceReview.vue Refactors from PrimeVue form resolver to manual Yup validation
Comments suppressed due to low confidence (1)

app/Filament/Admin/Resources/ComputerScienceResource.php:1

  • Inconsistent deletion behavior: individual delete action uses forceDelete() but bulk delete uses delete(). Both should use the same deletion method for consistency.
<?php

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@AllanKoder AllanKoder merged commit 645ddd7 into master Aug 29, 2025
3 checks passed
@AllanKoder AllanKoder deleted the More-edits branch August 29, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant