Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements URL normalization for resources and enhances the admin board functionality. The changes ensure that duplicate resources with slight URL variations (like trailing spaces or different cases) are properly handled by normalizing URLs before comparison.
- Creates a centralized URL normalization utility that trims, lowercases, and removes trailing slashes
- Implements URL normalization across resource creation, editing, and duplicate detection
- Refactors resource edits service to include change calculation logic and adds admin board fields
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/Utilities/UrlUtilities.php | New utility class for URL normalization |
| app/Models/ComputerScienceResource.php | Adds URL normalization to page_url attribute setter |
| app/Models/ResourceEdits.php | Normalizes page_url in proposed changes setter |
| app/Services/ComputerScienceResourceService.php | Uses normalized URLs for duplicate detection |
| app/Services/DataNormalizationService.php | Adds URL normalization to general data normalization |
| app/Services/ResourceEditsService.php | Moves change calculation logic and adds normalization method |
| app/Http/Controllers/ResourceEditsController.php | Refactors to use ResourceEditsService for change calculation |
| app/Filament/Admin/Resources/ComputerScienceResource.php | Adds page_url field to admin form and table |
| tests/Feature/ComputerScienceResourceTest.php | Updates test to verify URL normalization with trailing spaces |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…omputerScienceResources.com into page-url-whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.