Skip to content

Comments

Normalization and admin board#35

Merged
AllanKoder merged 7 commits intomasterfrom
page-url-whitespace
Aug 29, 2025
Merged

Normalization and admin board#35
AllanKoder merged 7 commits intomasterfrom
page-url-whitespace

Conversation

@AllanKoder
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings August 29, 2025 21:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements URL normalization for resources and enhances the admin board functionality. The changes ensure that duplicate resources with slight URL variations (like trailing spaces or different cases) are properly handled by normalizing URLs before comparison.

  • Creates a centralized URL normalization utility that trims, lowercases, and removes trailing slashes
  • Implements URL normalization across resource creation, editing, and duplicate detection
  • Refactors resource edits service to include change calculation logic and adds admin board fields

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
app/Utilities/UrlUtilities.php New utility class for URL normalization
app/Models/ComputerScienceResource.php Adds URL normalization to page_url attribute setter
app/Models/ResourceEdits.php Normalizes page_url in proposed changes setter
app/Services/ComputerScienceResourceService.php Uses normalized URLs for duplicate detection
app/Services/DataNormalizationService.php Adds URL normalization to general data normalization
app/Services/ResourceEditsService.php Moves change calculation logic and adds normalization method
app/Http/Controllers/ResourceEditsController.php Refactors to use ResourceEditsService for change calculation
app/Filament/Admin/Resources/ComputerScienceResource.php Adds page_url field to admin form and table
tests/Feature/ComputerScienceResourceTest.php Updates test to verify URL normalization with trailing spaces

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AllanKoder AllanKoder merged commit 0729ef7 into master Aug 29, 2025
3 checks passed
@AllanKoder AllanKoder deleted the page-url-whitespace branch August 29, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant