Skip to content

Comments

Quality of Life#38

Merged
AllanKoder merged 12 commits intomasterfrom
small-fixes
Sep 10, 2025
Merged

Quality of Life#38
AllanKoder merged 12 commits intomasterfrom
small-fixes

Conversation

@AllanKoder
Copy link
Owner

  • Dark Mode
  • Tags query with sanitized string
  • Resource button has nicer UI
  • Create resource page has helper info
  • Create resource page can save local images

Copilot AI review requested due to automatic review settings September 10, 2025 16:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive dark mode support to the application, improves the tagging system with sanitized queries, enhances UI components, adds helper information for resource creation, and enables local image saving functionality. The changes span theming configuration, Vue components, and form handling to create a more polished user experience.

  • Dark mode implementation with theme switching and styled components
  • Enhanced tag selection with better query handling and sanitization
  • Improved resource creation flow with helper modals and local image support

Reviewed Changes

Copilot reviewed 47 out of 50 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
theming.config.js Added dark mode color scheme configuration
resources/js/app.js Configured PrimeVue dark mode selector
resources/js/Composables/useDarkMode.js New composable for dark mode state management
Multiple Vue components Added dark mode class variants throughout UI
resources/js/Components/Form/TagSelector.vue Enhanced tag query sanitization and dark theme support
resources/js/Pages/Resources/MandatoryFields.vue Added description helper modal and local image handling
resources/js/Helpers/labels.js Improved pricing option descriptions
Comments suppressed due to low confidence (1)

resources/js/Helpers/validation.js:73

  • There's a TODO comment indicating that validation doesn't work correctly, and there's also a spelling error in the TODO comment ('NTO' should be 'NOT'). The validation logic should be reviewed and fixed to ensure proper functionality, and the TODO should be addressed or removed if the issue is resolved.
    // TODO: THIS VALIDATION DOES NTO WORK CORRECTLY
    pros: array()
        .transform((_value, originalValue) => {
            // Handle case where PrimeVue might pass a string instead of array
            if (typeof originalValue === "string") {
                return originalValue.trim() ? [originalValue.trim()] : [];
            }
            return Array.isArray(originalValue) ? originalValue : [];
        })

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +1 to +25
import { definePreset } from "@primevue/themes";
import Aura from "@primevue/themes/aura";

const customTheme = definePreset(Aura, {
font: {
family: "Open Sans",
},
semantic: {
primary: {
50: "{orange.50}",
100: "{orange.100}",
200: "{orange.200}",
300: "{orange.300}",
400: "{orange.400}",
500: "{orange.500}",
600: "{orange.600}",
700: "{orange.700}",
800: "{orange.800}",
900: "{orange.900}",
950: "{orange.950}",
},
}
});

export default customTheme;
Copy link

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file appears to be a duplicate of the root-level theming.config.js file with identical content but missing the dark mode color scheme configuration. This creates code duplication and inconsistency. Consider removing this duplicate file or ensuring it serves a different purpose with appropriate differentiation.

Suggested change
import { definePreset } from "@primevue/themes";
import Aura from "@primevue/themes/aura";
const customTheme = definePreset(Aura, {
font: {
family: "Open Sans",
},
semantic: {
primary: {
50: "{orange.50}",
100: "{orange.100}",
200: "{orange.200}",
300: "{orange.300}",
400: "{orange.400}",
500: "{orange.500}",
600: "{orange.600}",
700: "{orange.700}",
800: "{orange.800}",
900: "{orange.900}",
950: "{orange.950}",
},
}
});
export default customTheme;

Copilot uses AI. Check for mistakes.
Comment on lines +115 to 117
Since there are no existing votes (positive or negative), the entire community can merge any edits.
The reasoning is that someone could've made a typo and needed a quick fix.
Everyone automatically upvotes their own resources. So, you must unvote your newly created resource to reach 0 votes.
Copy link

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removed <th></th> tags were invalid HTML elements inside a table cell (<td>). While this fixes the HTML structure issue, the content should be properly formatted with paragraph tags or line breaks for better readability and semantic structure.

Suggested change
Since there are no existing votes (positive or negative), the entire community can merge any edits.
The reasoning is that someone could've made a typo and needed a quick fix.
Everyone automatically upvotes their own resources. So, you must unvote your newly created resource to reach 0 votes.
<p>Since there are no existing votes (positive or negative), the entire community can merge any edits.</p>
<p>The reasoning is that someone could've made a typo and needed a quick fix.</p>
<p>Everyone automatically upvotes their own resources. So, you must unvote your newly created resource to reach 0 votes.</p>

Copilot uses AI. Check for mistakes.
@AllanKoder AllanKoder merged commit 3500eda into master Sep 10, 2025
3 checks passed
@AllanKoder AllanKoder deleted the small-fixes branch September 10, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant