Resolves deprecation warnings on elixir 1.17 #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error messages in these tests were more verbose, echoing back the original query. Rather than expand the expected string, matching on the more relevant portion of the observed string (including the error codes) seemed more tenable. I'm also uncertain if the version (or a setting) of mysql may impact the verbosity of the returned error message.
* Logger has changed "warn" to "warning" level * "module.__function__" now outputs a warning message about implicit function calls, suggests using "module.__function__()" * Exception.exception?/1 replaced by Kernel.is_exception/1 * Regex.regex?/1 replaced by Kernel.is_struct/2 * Some ecto callbacks take different numbers of parameters, so TestAdapter no-op function implementations updated.
Regenerate credo config, keeping opted-in checks, using very slightly relaxed parameters for duplicated code and nesting (both 3 over defaults of 2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of ateliware#95 - resolving deprecations related to upgrading to elixir 1.17