Skip to content

Conversation

@ElaineSvartis
Copy link
Contributor

@ElaineSvartis ElaineSvartis commented Dec 16, 2025

Description

Oppdatert logo og emblem for srf - Statens Sivilrettsforvaltning

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

  • Chores
    • Updated organizational branding assets with improved vector-based SVG logo format, replacing the previous PNG version.
    • Added new emblem resource to enhance organizational visual identity.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 16, 2025

📝 Walkthrough

Walkthrough

The srf organizational entry in the altinn organizations configuration was updated to replace the PNG logo with an SVG logo and add a new emblem URL asset.

Changes

Cohort / File(s) Summary
Organizational branding assets
orgs/altinn-orgs.json
Updated srf organization's logo URL from PNG to SVG format; added emblem URL property for branding resources

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • nkylstad

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes in the pull request, which involve updating the logo and adding an emblem for the srf organization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 296049b and 2dc08dd.

⛔ Files ignored due to path filters (3)
  • orgs/srf/SRF_emblem.svg is excluded by !**/*.svg
  • orgs/srf/SRF_logo.svg is excluded by !**/*.svg
  • orgs/srf/srf.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • orgs/altinn-orgs.json (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: nkylstad
Repo: Altinn/altinn-cdn PR: 214
File: orgs/altinn-orgs.json:86-88
Timestamp: 2025-07-03T13:05:44.903Z
Learning: In the Altinn CDN repository, asset URLs in JSON files may return 404 during PR review because the assets are part of the PR and only become available after the PR is merged and deployed to the CDN. This is normal behavior for the deployment process.
🔇 Additional comments (1)
orgs/altinn-orgs.json (1)

761-762: LGTM! Clean branding asset update.

The logo format upgrade to SVG and the addition of an emblem field are consistent with other organizational entries in this file (e.g., brm, mat, ssb, vigo). The JSON structure and URL format follow the established patterns correctly.

Based on learnings, note that the asset URLs may return 404 during review since they're part of the PR and will become available after merge and deployment to the CDN.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nkylstad nkylstad merged commit a7bde1e into Altinn:master Dec 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants