-
Notifications
You must be signed in to change notification settings - Fork 87
chore: Remove some legacy studio components #17361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughRemoved multiple deprecated legacy UI components, their stories, tests, docs and styles from the studio-components-legacy package; updated a consumer to import StudioHeading from the new package and added explicit props for the 404 heading. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested labels
Suggested reviewers
Poem
Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…oggleableTextfieldSchema
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17361 +/- ##
==========================================
- Coverage 96.26% 96.24% -0.03%
==========================================
Files 2384 2392 +8
Lines 30282 30380 +98
Branches 3529 3542 +13
==========================================
+ Hits 29150 29238 +88
- Misses 820 832 +12
+ Partials 312 310 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JamalAlabdullah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! 👍
Description
StudioHeadingone place, see image before and after.StudioHeading,StudioIconTextfield,StudioToggleableTextfieldandStudioToggleableTextfieldSchemaNot necessary to test this PR, and code review can mostly be
ContentLibrary.tsxBefore image
After image:
Verification