Skip to content

Fixing stray error message in expression validation #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olemartinorg merged 2 commits into from
Jan 5, 2026
Merged

Fixing stray error message in expression validation #3916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96fa68b
Testing a fix that I'm really unsure about, but may work
Dec 17, 2025
dcff135
Message can also be an expression now, this was missed in #3454
Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion schemas/json/validation/validation.schema.v1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"message": {
"title": "Validation message",
"description": "The message to display when the validation fails.",
"type": "string"
"$ref": "../layout/expression.schema.v1.json#/definitions/string"
},
"condition": {
"title": "Expression returning a boolean value",
Expand Down
2 changes: 1 addition & 1 deletion src/features/formData/FormDataWrite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,7 @@ export const FD = {

const paths: string[] = [];
collectMatchingFieldPaths(formData, reference.field.split('.'), '', 0, paths);
return paths.length === 0 ? [reference.field] : paths.sort();
return paths.sort();
});
},

Expand Down