Open
Conversation
Fitzmaz
pushed a commit
to Fitzmaz/MWICombatSimulatorTest
that referenced
this pull request
Aug 20, 2025
fix: party combat drop logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the
distfolder in the repository is not really ideal and can cause issues, github pages should be building it from the source, this PR aims to fix this.This is adds an custom workflow that handles building the webpack, generating an artifact and using it as an source for the github page instead, this is triggered by publishing an release (can be changed to be triggered by every commit).
The page settings will need to be changed from
Deploy from branchtoGithub Actionsin order for this to work.