Draft
Conversation
lbam
force-pushed
the
lb/gebieden
branch
2 times, most recently
from
f1e919d to
730456c
Compare
UNESCO zones still read from legacy database because the data hasn't landed in the refdb yet. See gen_gebieden.py for more loose ends.
jjmurre
approved these changes
Feb 19, 2024
Contributor
jjmurre
left a comment
jjmurre
left a comment
There was a problem hiding this comment.
LGTM, question about naming.
Nice approach with the blocks!
Contributor
Author
|
Converted back to draft as the structure of this mapfile needs further reviewing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not everything is ported over, because not everything is in the refdb yet. Relevant parts of the mapfile generator have been marked.