Make Identity Pool / IAM authorization optional, fall back to JWT authorization if not provided#31
Open
shaunhurley wants to merge 1 commit intoAnomalyInnovations:masterfrom
Open
Conversation
…horization if not provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiya, another unsolicited pull request, sorry! Super useful test utility, but I'm doing a bunch of JWT authorization based stuff.
Originally went with a separate makeJWTRequest() function and bypassed getCredentials altogether approach, however figured this approach was less duplication.
Only other thought was potentially pulling out additionalParams to a global, so I could handle the Authorization header in the getCredentials() bypass and avoid doing another argv.identityPoolId check in makeRequest(), which would make things a little cleaner, but didn't implement. Not sure on your philosophy on globals :)