Skip to content

Add CI with ruff and pytest, run format#37

Open
qdegraaf wants to merge 2 commits intoAnswerDotAI:mainfrom
qdegraaf:feat/addghaction
Open

Add CI with ruff and pytest, run format#37
qdegraaf wants to merge 2 commits intoAnswerDotAI:mainfrom
qdegraaf:feat/addghaction

Conversation

@qdegraaf
Copy link

@qdegraaf qdegraaf commented Oct 7, 2024

Couldn't find any contributing rules, so let me know if I'm missing any due diligence! This PR adds some basic CI to make further development easier.

Summary

  • Adds basic CI github workflow to run tests for Python 3.9-3.12 (3.8 loses support this month, so removed it)
  • Ran ruff format
  • Fixed tests by changing id= param to doc_id

Initially this had a typecheck step as well, but mypy complains about quite a few things, so that's probably best handled in a separate PR for clarity purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments