Compatibility Updates #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several dependencies were outdated or completed unsupported. Updated Illuminate version. Removed DataTransferObject. Replaced with eventsauce/object-hydrator. For some fields, even though AT says they are required, I have seen the API return null values for them. Therefore, I decided to make them all nullable. Maybe that is not the best approach, but we cannot count on AT to be consistent. Added templates for mocks to use during testing.
Added some old DTO methods back to Entity base class Made other entities extend the class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily, the dependency on the deprecated Spatie DataTransferObject has been removed and replaced with the EventSaucePHP ObjectHydrator. Versions of other dependencies have been updated, and the generated code is PHP 8.3 compatible. All hydrated fields are now nullable, because AT sometimes has null values on fields it says are required.