Update API endpoint URL#172
Merged
sdfordham merged 2 commits intoAnthonyBloomer:masterfrom May 25, 2025
Merged
Conversation
Collaborator
|
Thanks for this, could you change the workflow to run on ubuntu-22.04 that should get the tests workflow to trigger properly |
Contributor
Author
Just did that there. Thanks for pointing me in the right direction! |
sdfordham
approved these changes
May 25, 2025
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Daft API endpoint from https://gateway.daft.ie/old/v1/listings to https://gateway.daft.ie/api/v2/ads/listings. The previous endpoint doesn't seem to be working anymore (returns a HTTP 403).
All tests have been run and are passing with the updated endpoint. Code formatting checked with Black.