-
Notifications
You must be signed in to change notification settings - Fork 27
Fixed ABI version caused issues when using CUDA 12.8 #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MrZoyo
wants to merge
27
commits into
Anttwo:master
Choose a base branch
from
MrZoyo:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
This pull request introduces several improvements and fixes across mesh processing, rasterization, and C++ extension compatibility.
I need to clarify: some changes were made for my personal testing convenience. For instance, since my GPU VRAM configuration is low, I had to rewrite
nvdiff_rasterizationto use chunked processing to reduce VRAM overflow. Theclean_convert_mesh.pyscript was created for my personal convenience in obtaining obj/glb formats.These changes have only been tested on my specific device and configuration, without extensive verification.
Modifications to header files to enforce ABI=1 may adversely affect users of older versions. I apologize for not having older hardware available for testing.
These concerns are also why I didn't submit a PR earlier. I request that your team test my modifications whenever feasible and feel free to make any changes.
===========================================
Mesh Processing Utility:
clean_convert_mesh.pyfor cleaning, simplifying, and converting mesh files (PLY/OBJ/GLB) with options for component filtering and triangle count reduction. This script leveragespymeshlaband optionallytrimeshfor robust mesh handling and exports.Rasterization Improvements:
nvdiff_rasterizationfunction inmesh.pythat supports chunked rasterization for large meshes (controlled via theMILO_RAST_TRI_CHUNKenvironment variable) and fixes a critical compatibility issue by ensuring therangesargument for nvdiffrast is always on the CPU.glorcuda) via theNVDIFRAST_BACKENDenvironment variable, improving flexibility for different hardware setups.C++ Extension Compatibility:
Added a new header
force_abi.hto force use of the C++11 ABI for GCC's libstdc++ in the tetra_triangulation extension, preventing runtime linker errors with recent PyTorch versions. This header is now included as the first line in all relevant C++ sources.CUDA and Header Hygiene:
Added missing standard headers (
<cstdint>,<cstddef>) to several rasterizer implementations for improved portability and reliability.Fixed CUDA pointer usage in
spatial.cuby switching from.data<float>()to.data_ptr<float>()for compatibility with newer PyTorch versions.Added
<cfloat>tosimple_knn.cuand removed redundant macro definition for better CUDA compilation hygiene.