⚡ Bolt: Optimize HistoryScreen mapping #101
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
menny
force-pushed
the
bolt-history-optimization-12837632712009677003
branch
from
019eb55 to
20127db
Compare
💡 What: Moved the mapping of `Translation` (DB entity) to `UiTranslation` (UI model) from the UI layer (`HistoryScreen` composable) to `HistoryViewModel`. This mapping now executes on `Dispatchers.Default` using the `flowOn` operator. 🎯 Why: Previously, `HistoryScreen` mapped the entire history list on the main thread inside a `remember` block. While `remember` prevents re-execution on every recomposition, the initial calculation and updates blocked the UI thread. For large history lists, this could cause frame drops. Moving this to the ViewModel ensures the UI only collects ready-to-render data. 📊 Impact: Reduces main thread work during history updates. Simplifies `HistoryScreen` by removing transformation logic. 🔬 Measurement: Static analysis confirms the mapping is now backgrounded. Manual verification: Compile and verify type safety.
menny
force-pushed
the
bolt-history-optimization-12837632712009677003
branch
from
20127db to
82cdac4
Compare
1 participant
Moved the
TranslationtoUiTranslationmapping fromHistoryScreentoHistoryViewModel, running it on a background thread to unblock the UI.PR created automatically by Jules for task 12837632712009677003 started by @menny