chore: eas build 설정 #4
Conversation
There was a problem hiding this comment.
Pull request overview
This PR configures EAS (Expo Application Services) build settings for the frontend mobile application. The changes migrate from a JSON-based app configuration to a TypeScript-based configuration system and set up build profiles for development, preview, and production environments.
- Configures EAS build profiles with platform-specific build types (APK for Android development/preview, app-bundle for production)
- Migrates app configuration from app.json to app.config.ts with added EAS project ID and platform-specific settings
- Sets up iOS app submission configuration with Apple credentials
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| frontend/eas.json | Configures EAS CLI version, build profiles (development/preview/production), and iOS submission settings with Apple credentials |
| frontend/app.json | Removed in favor of TypeScript-based configuration |
| frontend/app.config.ts | Adds EAS project ID, iOS encryption export compliance setting, and spreads existing config for platform compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "appleId": "mark77234@icloud.com", | ||
| "appleTeamId": "GQ89YG5G9R" |
There was a problem hiding this comment.
The Apple ID email address "mark77234@icloud.com" and Apple Team ID "GQ89YG5G9R" are hardcoded in the configuration file. These sensitive credentials should not be committed to version control as they can be publicly exposed. Consider using environment variables or a secure credential management system instead. For example, these values should be stored in a .env file or injected during the build process through EAS secrets.
| "appleId": "mark77234@icloud.com", | |
| "appleTeamId": "GQ89YG5G9R" |
| "cli": { | ||
| "version": ">= 13.2.1", | ||
| "appVersionSource": "remote" | ||
| "version": ">= 11.0.0", |
There was a problem hiding this comment.
The CLI version requirement has been downgraded from ">= 13.2.1" to ">= 11.0.0". This is a significant downgrade (approximately 2 major versions) and may result in missing newer features, bug fixes, and security patches available in more recent EAS CLI versions. Consider using a more recent version requirement unless there's a specific compatibility reason for this downgrade.
| "version": ">= 11.0.0", | |
| "version": ">= 13.2.1", |
| "version": ">= 13.2.1", | ||
| "appVersionSource": "remote" | ||
| "version": ">= 11.0.0", | ||
| "appVersionSource": "local" |
There was a problem hiding this comment.
The appVersionSource has been changed from "remote" to "local". This means version numbers will now be managed locally in your configuration files rather than remotely on EAS servers. Ensure that you have a process in place to manually increment version numbers for each release, as automatic version management will no longer be handled by EAS.
| "appVersionSource": "local" | |
| "appVersionSource": "remote" |
| "production": { | ||
| "autoIncrement": true | ||
| "distribution": "store", | ||
| "android": { | ||
| "buildType": "app-bundle" | ||
| }, | ||
| "ios": { | ||
| "simulator": false | ||
| } |
There was a problem hiding this comment.
The production build configuration has removed the "autoIncrement" setting which was previously configured. This removal, combined with the change to "local" appVersionSource, means version numbers will no longer be automatically incremented for production builds. This could lead to version conflicts or forgotten version updates when releasing to the store.
작업내용