feat: Added libfvad library and integrated Voice Activity Detection#457
Open
srikaranth wants to merge 4 commits intomainfrom
Open
feat: Added libfvad library and integrated Voice Activity Detection#457srikaranth wants to merge 4 commits intomainfrom
srikaranth wants to merge 4 commits intomainfrom
Conversation
added unit test for VAD
Contributor
yashrajsapra
requested changes
Dec 11, 2025
| p.wait_for_all(); | ||
| } | ||
|
|
||
| BOOST_AUTO_TEST_CASE(vad_aggressiveness_test, *boost::unit_test::disabled()) |
Collaborator
There was a problem hiding this comment.
Incomplete test for now, Please add src to verify , all the different modes
base/CMakeLists.txt
Outdated
| include/ColorConversionXForm.h | ||
| include/Overlay.h | ||
| include/AudioToTextXForm.h | ||
| include/VADTransform.h |
Collaborator
There was a problem hiding this comment.
Please Rename it to VoiceAudioDetector
base/CMakeLists.txt
Outdated
| bigint::bigint | ||
| sfml-audio | ||
| whisper::whisper | ||
| fvad |
Collaborator
There was a problem hiding this comment.
Can we bring it from vcpkg
|
|
||
| enum FrameLength { | ||
| FRAME_10MS = 10, | ||
| FRAME_20MS = 20, |
Collaborator
There was a problem hiding this comment.
Please add comments to describe this modes, as in effects of setting frame length
| bool init() | ||
| { | ||
| // Create libfvad instance | ||
| mVad = fvad_new(); |
Collaborator
There was a problem hiding this comment.
Please use complete name (avoid abbreviation )
|
|
||
| // Test all 4 aggressiveness modes | ||
| VADTransformProps::AggressivenessMode modes[] = { | ||
| VADTransformProps::QUALITY, |
Collaborator
There was a problem hiding this comment.
Seems we are supporting getProps and setProps , Please add UT for same
| auto outFrame = makeFrame(sizeof(int)); | ||
| int vadResult = (result == 1) ? 1 : 0; | ||
| memcpy(outFrame->data(), &vadResult, sizeof(int)); | ||
|
|
Collaborator
There was a problem hiding this comment.
We should also send input frame also , along with Voice Detection info
1. renamed vad ->voice activity detector 2. bringing fvad from vcpkg 3 . made changes in unit test 4. sending input frame also , along with Voice Detection info
false:audio has booth speech and silence true:audio has only speech
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.