Print characters 'c with high bit set as 'c|$80; bump version#8
Open
0cjs wants to merge 1 commit intoArakula:masterfrom
Open
Print characters 'c with high bit set as 'c|$80; bump version#80cjs wants to merge 1 commit intoArakula:masterfrom
0cjs wants to merge 1 commit intoArakula:masterfrom
Conversation
|
I'd like to see this added as well. The project I'm working on now uses the high bit to show characters inverted, and I believe uses like this are fairly common. Should there be an option to enable/disable this, or is there something else in the way of merging it? |
This is very useful for programs that set the high bit of characters
to indicate end of string or for some other reason. Sample output:
FCB 'E,'N,'D|$80 ;015C: 45 4E C4 'EN.'
This applies only to memory locations explicitly marked as `char`
(in the info file). If you're doing a disassembly later to be
assembled by an assembler that doesn't support this "logical or"
syntax you can either not mark those bytes as `char` or, if you've
marked a large range like `char 015C-0233`, add additional directives
after that to mark individual bytes as non-char, e.g., `hex 015E` to
would produce `$C4` instead of `'D|$80` in the output above.
This syntax is supported by AS and A09, but does not appear to be
supported by TSC.
Contributor
Author
|
I'd totally forgotten that I submitted this five years ago. Yes, it would be nice to get it merged, and I'm happy to add an option if that's really necessary (though I don't feel the need for it myself). |
Contributor
Author
|
Just checking back in to see if there's anything here I need to change to make it more suitable for merging. |
Contributor
Author
|
Checking back again... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very useful for programs that set the high bit of characters
to indicate end of string or for some other reason. Sample output:
This applies only to memory locations explicitly marked as
char(in the info file). If you're doing a disassembly later to be
assembled by an assembler that doesn't support this "logical or"
syntax you can either not mark those bytes as
charor, if you'vemarked a large range like
char 015C-0233, add additional directivesafter that to mark individual bytes as non-char, e.g.,
hex 015Etowould produce
$C4instead of'D|$80in the output above.This syntax is supported by AS and A09, but does not appear to be
supported by TSC.
This is related to issue #7, which includes an old (and somewhat incorrect) version of this patch. While there were some thoughts there about how to expand this feature, at the moment there seems to be no particular demand for anything beyond what this does now.