-
Notifications
You must be signed in to change notification settings - Fork 21
Transactions #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transactions #73
Conversation
…sesql-module Use parsesql for table name detection
Co-authored-by: Andreas Rumpf <araq4k@proton.me>
| retExpr: NimNode | ||
|
|
||
| # Execute a non-row SQL statement strictly (errors on failure) | ||
| template execNoRowsStrict*(sqlStmt: string) = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, so that is something GPT5 added. I'd committed the first changes already when I saw these. It looked odd but I figured they already existed.
I'm not sure if these are any better to use than a plain db.exec. Is doing the prepare statement and query steps beneficial? Seems like a bit of AI slop to drop.
Co-authored-by: Andreas Rumpf <araq4k@proton.me>
|
Good enough for me. Further improvements can be done as new PRs. |
This takes a different, simpler approach than the other PR. Transactions are just simple try excepts that handle setting up transactions instead of trying make
querysupport multi-statements and then including transactions in the DSL.Outer try excepts: