Fixed bug where charts remain loaded after the chart is closed.#57
Draft
Renjian-buchai wants to merge 5 commits intoArcthesia:devfrom
Draft
Fixed bug where charts remain loaded after the chart is closed.#57Renjian-buchai wants to merge 5 commits intoArcthesia:devfrom
Renjian-buchai wants to merge 5 commits intoArcthesia:devfrom
Conversation
Author
|
Not fixed, it removed 1 reference, but there's still one remaining |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug may be caused because, while Dispose was called on the Values of every single dictionary, the dictionary itself is never cleared, and hence, the Keys were never cleared.
With my current testing, I think I've fixed it, but I'll do further testing.