Skip to content

refactor: add transactions configuration endpoint #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ItsANameToo merged 3 commits into from
Mar 27, 2025
Merged

refactor: add transactions configuration endpoint #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5b661e
refactor: add transactions configuration endpoint
alexbarnsley Mar 26, 2025
9f02bb6
remove redundant tx endpoint methods
alexbarnsley Mar 26, 2025
beecf41
test
alexbarnsley Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions client/api/transactions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,5 @@ def all_unconfirmed(self, limit=100, offset=None, **kwargs):
def get_unconfirmed(self, transaction_id):
return self.with_endpoint('api').request_get(f'transactions/unconfirmed/{transaction_id}')

def types(self):
return self.with_endpoint('api').request_get('transactions/types')

def fees(self):
return self.with_endpoint('api').request_get('transactions/fees')

def schemas(self):
return self.with_endpoint('api').request_get('transactions/schemas')
def configuration(self):
return self.with_endpoint('transactions').request_get('configuration')
14 changes: 9 additions & 5 deletions tests/api/test_transactions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,15 +135,19 @@ def test_all_unconfirmed_calls_correct_url_with_additional_params():
assert 'limit=69' in responses.calls[0].request.url
assert 'orderBy=timestamp.epoch' in responses.calls[0].request.url

def test_schemas_calls_correct_url():
def test_configuration_calls_correct_url():
responses.add(
responses.GET,
'http://127.0.0.1:4002/api/transactions/schemas',
'http://127.0.0.1:4002/tx/api/configuration',
json={'success': True},
status=200
)

client = ArkClient('http://127.0.0.1:4002/api')
client.transactions.schemas()
client = ArkClient({
'api': 'http://127.0.0.1:4002/api',
'transactions': 'http://127.0.0.1:4002/tx/api',
'evm': None,
})
client.transactions.configuration()
assert len(responses.calls) == 1
assert responses.calls[0].request.url == 'http://127.0.0.1:4002/api/transactions/schemas'
assert responses.calls[0].request.url == 'http://127.0.0.1:4002/tx/api/configuration'