fix(jwk): add validation for jwks#224
Open
atticusofsparta wants to merge 1 commit intoArweaveTeam:masterfrom
Open
fix(jwk): add validation for jwks#224atticusofsparta wants to merge 1 commit intoArweaveTeam:masterfrom
atticusofsparta wants to merge 1 commit intoArweaveTeam:masterfrom
Conversation
Member
|
not going to merge this straight away.
|
Author
|
Agreed, ideally the validateJWK implements checked based on the spec (byte length and regex check). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into an issue across multiple apps that pull in the jwk and create an address with invalid jwk.n keys.
This validates the JWK by verifying the signature when signing transactions and when generating a wallet address. Should help prevent people accidentally sending tokens to their wallet when onboarding (as is what happend to me)