feat: speedup slash #159
Open
feat: speedup slash #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FauxFaux
force-pushed
the
feat/speedup-slash
branch
from
fa59e08 to
0d03eb1
Compare
Merged
FauxFaux
force-pushed
the
feat/speedup-slash
branch
from
0d03eb1 to
f31bab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The start of this branch, which is kinda reasonable, is roughly 4x improvement onThis was all merged.(+/%#)i. 1e7here; 14-ish to 3-ish seconds. (I don't approve of the benchmark strategy.)Most of the remaining time is being spent inside v_plus converting to and from JArray -> Num::Int -> i64 -> Num::Int -> JArray and back again.The end ofthis branch adds a fastpath for the "sum idiom" explicitly, and now we're faster than python and ijconsole, although ijconsole is probably spending most of its time loading the stdlib and not running the code.I don't think we should add this fastpath until we can work out what the generic form of this is. What property of
+makes this possible, and where do we store whether something has that property?(Also, do we handle overflows? Should we?)