Change recording framerate to 59.94 fps #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when recording to a file the framerate is at 62.5fps, which introduces some inaccuracies in video editors.
I maybe should've left all the logic in place to keep it at 60 but technically 59.94(60 frames per 1.001 seconds) is more correct as this is the output framerate of the Wii and also the internal framerate of MKW.
Initially i wanted to rewrite the timer for normal playback as well but this wasn't as simple as i expected it to be so that's why i only set the framerate of the animator to 59.94 there.
Unfortunately i did introduce some bugs with the timer in recordings, the first 2 frames have the exact same time and the end time is close to 2 frames off now, so maybe instead have an option to display framecount instead of framecount converted to time?
ffmpeg also should have a way to burn the timecode into a video so that might be a better approach