This repository was archived by the owner on Jul 21, 2022. It is now read-only.
Open
Conversation
Contributor
Author
|
please ignore the YML file change, I dun goofed |
lawschlosser
suggested changes
Apr 12, 2018
Contributor
lawschlosser
left a comment
lawschlosser
left a comment
There was a problem hiding this comment.
A couple questions:
- judging by the name of this branch, I'm wondering if some of this code is accidental. It looks like you have both the mtoa updates, as well as uploader profiling changes?
- The jira ticket in the the branch name (CT-181) doesn't align with any of this work? Is this the correct ticket number?
- If indeed you were intending to merge all of this code into master, I don't think we should introduce this profiling code into the uploader code. If you want to keep this simply as a separate branch, then all good.
Contributor
Author
|
To answer your questions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.