Feature/ct 194/memcached uploader urls

[lawschlosser]

No description provided.

[WMDConductor]

LGTM - with small exception catching nit + Codacy considerations assumed sorted out.

[WMDConductor]

Seems like we could make this: catch explicit:

except (ValueError, TypeError):

[flebel]

from x import y go after import x statements.

eg. this is what isort gives me:

import base64
import datetime
import functools
import hashlib
import json
import logging
import multiprocessing
import os
import platform
import random
import signal
import subprocess
import sys
import time
import traceback
from pprint import pformat

import yaml

[lawschlosser]

We should probably decide as a team on how we want to sort imports. I haven't seen much in google style guide or pep8 (aside from grouping imports by builtin, thirdparty, internal).
Personally, I sort imports alphabetically, considering the uppermost namespace (parent packages) when evaluating order. I don't distinguish/consider whether it's a from vs import. I find that it makes it easier for me to look something up, if there is one continuous alphabetical ordering, rather than having multiple sections of their own ordering. But we're all weird humans, thinking in weird ways.

also, I noticed that isort has several different options that make dramatic differences (--no-sections, --order-by-type, --project, --thirdparty , etc). Might be worth playing around with these to find a workflow something that we all like (dislike ;) ).

[flebel]

Good call, let's make this a team decision.

[flebel]

s/troll/scroll/

[lawschlosser]

That was the intended spelling. But after reading this: https://english.stackexchange.com/questions/122627/trawling-through-or-trolling-through
....I'm wondering if I should just change it to your recommendation (English is so hard!)

[flebel]

except: would also work as a catch-all.

[lawschlosser]

I've been going back and forth on this recently (due to recent revelations that I'm somewhat embarrassed about). And coincidentally, this module makes for the perfect example!
As much as I have loved to catch all exceptions by simply not listing any specific types (when deemed appropriate), I didn't realize there was a subtle difference in doing so vs explicitly catching the Exception class. See https://stackoverflow.com/questions/730764/how-to-properly-ignore-exceptions

Usually it doesn't matter if we "catch all" exception, but because this module's application (the uploader), is a long running (daemon) process, that can only be stopped via killing it (ctrl-c, sigint, sigterm, etc), we have to be thoughtful to not disrupt any logic in the uploader that is expecting to encounter ctrl-c (KeyboardInterrupt).
Here's a great example of how you can unintentionally make trouble : https://fman.io/blog/an-inescapable-while-loop-in-python/

side note: here's an interesting diagram/hierarchy of pythons exception classes (as well as general good reading): https://airbrake.io/blog/python-exception-handling/class-hierarchy

[flebel]

Can you rename the method to kill_metric_store for consistency with the above variable self.metric_store?

[lawschlosser]

sure, makes sense

[flebel]

This can be simplified to except:.

[lawschlosser]

#192 (comment)

[flebel]

Good call, let's make this a team decision.