This repository was archived by the owner on Jul 21, 2022. It is now read-only.
Open
Conversation
jesseconductor
approved these changes
Aug 27, 2020
flebel
approved these changes
Aug 31, 2020
lawschlosser
reviewed
Sep 1, 2020
Contributor
lawschlosser
left a comment
lawschlosser
left a comment
There was a problem hiding this comment.
Because our regexing is executed without case-sensitivity, I would suggest that we keep our regex patterns as simple as possible, e.g. <f\d*> or <F\d*>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tested here:
https://regex101.com/r/bjjWjb/1/
Not tested with a Renderman scene yet.
In keeping with other regexes, it accepts any number of digits after
f. This is probably not necessary - no one ever pads 10 zeros.