ar_osal: Add Zephyr logging support with Kconfig integration#55
Open
quic-aditrath wants to merge 1 commit intoAudioReach:masterfrom
Open
ar_osal: Add Zephyr logging support with Kconfig integration#55quic-aditrath wants to merge 1 commit intoAudioReach:masterfrom
quic-aditrath wants to merge 1 commit intoAudioReach:masterfrom
Conversation
Add conditional compilation to support Zephyr's native logging system alongside the existing Android/Linux implementation. The Zephyr implementation leverages the native logging subsystem for automatic timestamp generation, module prefixing, and output routing, with compile-time log level configuration through Kconfig symbol CONFIG_ARE_LOG_LEVEL. Signed-off-by: Aditya Rathi <aditrath@qti.qualcomm.com>
quic-plai
reviewed
Feb 8, 2026
| _IRQL_requires_max_(DISPATCH_LEVEL) | ||
| void ar_log_init(void) | ||
| { | ||
| #ifdef __ZEPHYR__ |
Contributor
There was a problem hiding this comment.
should we have #ifndef to avoid empty line?
|
|
||
| #ifdef __ZEPHYR__ | ||
| /* Use Zephyr logging macros */ | ||
| if (level == AR_DEBUG) { |
Contributor
There was a problem hiding this comment.
Seems like we can unify e.g instead of calling __android_log_write, call generic MACRO (LOG_DBG) instead. Then, map LOG_DBG to __android_log_write
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add conditional compilation to support Zephyr's native logging system alongside the existing Android/Linux implementation.
The Zephyr implementation leverages the native logging subsystem for automatic timestamp generation, module prefixing, and output routing, with compile-time log level configuration through Kconfig symbol CONFIG_ARE_LOG_LEVEL.