Skip to content

Conversation

@gavande1
Copy link
Contributor

@gavande1 gavande1 commented Dec 30, 2025

Related issues

Proposed Changes

  • Added error handling in getPushProgressInfo to catch network errors gracefully
  • Skip Sentry reporting for expected crossDomain network errors (offline scenarios)
  • Prevent unhandled promise rejections when network goes offline

Testing Instructions

  1. Start a new sync operation
  2. Allow the upload step to complete successfully
  3. Disconnect the network (e.g., turn off Wi‑Fi) during subsequent sync steps
  4. Verify the renderer no longer crashes and handles the offline state gracefully
  5. Verify that when the network reconnects, the sync operation can continue

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

- Add error handling in getPushProgressInfo to catch network errors gracefully
- Skip Sentry reporting for expected crossDomain network errors
- Prevent unhandled promise rejections when network goes offline

Fixes STU-1180
@gavande1 gavande1 self-assigned this Dec 30, 2025
@gavande1 gavande1 changed the title Fix renderer crash when network disconnects after upload (STU-1180) Sync: Fix renderer crash when network disconnects after upload Dec 30, 2025
@gavande1 gavande1 requested a review from a team December 30, 2025 07:52
@github-actions
Copy link
Contributor

📊 Performance Test Results

Comparing 3c6b618 vs trunk

site-editor

Metric trunk 3c6b618 Diff Change
load 17618.00 ms 15133.00 ms -2485.00 ms 🟢 -14.1%

site-startup

Metric trunk 3c6b618 Diff Change
siteCreation 30196.00 ms 29002.00 ms -1194.00 ms 🟢 -4.0%
siteStartup 11070.00 ms 12050.00 ms +980.00 ms 🔴 8.9%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants