-
Notifications
You must be signed in to change notification settings - Fork 54
Add details about unsupported Sync item states #2358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📊 Performance Test ResultsComparing 09287a6 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
gavande1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment about the issue with flashing tooltip on top left corner.
|
@gavande1 Interesting, I can't reproduce it. But I added |
|
@nightnei Unfortunately that didn't fix the issue as it seems. CleanShot.2026-01-08.at.13.28.01-converted.mp4
I totally agree. Would it make sense to identify the root cause and report the issue upstream repo in that case? |
|
@gavande1 I created issue (STU-1201) for it and set low priority, since it's not a blocker and it doesn't cause any UX problems. Also, the lib is used across the whole Studio, so it should be reproducible for you everywhere, and the changes in this PR are not the root cause for it. |
|
I see the same issue with the flashing tooltip although it does not happen with every tooltip, but for some sites it does. |
gavande1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this and creating STU-1201 for the tooltip issue!
After further review, I agree this PR should be merged:
- ✅ The code changes add valuable UX improvements
- ✅ The tooltip flashing is a pre-existing
@wordpress/componentslibrary issue, not introduced by this PR - ✅ STU-1201 properly tracks the tooltip issue for separate resolution
Approving this PR. The tooltip library issue can be investigated and fixed separately without blocking these helpful improvements.
|
Thank you for introducing these tooltips, Vova! |
| @@ -1,4 +1,4 @@ | |||
| import { Icon, SearchControl as SearchControlWp } from '@wordpress/components'; | |||
| import { Icon, SearchControl as SearchControlWp, Tooltip } from '@wordpress/components'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nightnei This PR uses Tooltip from @wordpress/components, but Studio uses a custom Tooltip from src/components/tooltip everywhere else. Switching to the custom component should fix the flashing and maintain consistency.

Proposed Changes
On Sync tab we render “Upgrade plan” button, w/o any details about which one should be chosen.
It can be frustrating for users, if they click in “Upgrade plan” button, purchase for example “Personal” and still Studio asks to upgrade plan, w/o any details.
This PR adds tooltip to specify Business plan.
And also adds tooltip to explain why the site is unsupported. It even usefull for us, developers of Studio, since I had no idea why site can be unsupported and why that predicate can be true, so I had to read commits history.
Testing Instructions
Unsupporteditem andUpgrade planbutton