Open
Conversation
To avoid using the ip command as subprocess, use the pyroute2 package to directly send the netlink commands. This does not change the behavior, but is a direct mapping of the ip commands. Signed-off-by: Florian Kauer <florian.kauer@linutronix.de>
If the VLAN interface already exists, the setup should not fail. In that case, check if the existing configuration is compatible and set the changes (in particular the egress-qos-map). Signed-off-by: Florian Kauer <florian.kauer@linutronix.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the VLAN interface is set up via the ip CLI and fails if it already exists.
Switch to directly interfacing via netlink and if the interface exists, ensure the configuration is correct, but do not fail.