Consider using not in per PEP 8#15
Open
dsiddy wants to merge 1 commit intoAzure-Samples:masterfrom
dsiddy:patch-1
Open
Consider using not in per PEP 8#15dsiddy wants to merge 1 commit intoAzure-Samples:masterfrom dsiddy:patch-1
not in per PEP 8#15dsiddy wants to merge 1 commit intoAzure-Samples:masterfrom
dsiddy:patch-1
Conversation
`pycodestyle`'s [rule E713](https://hyp.is/RMY0AHmrEeq0f9dUIBJwPA/pycodestyle.pycqa.org/en/latest/intro.html) mandates this, presumably because [PEP 8](https://www.python.org/dev/peps/pep-0008/) points out something similar: > Use `is not` operator rather than `not ... is`. While both expressions are functionally identical, the former is more readable and preferred[.] I happen to agree with this assessment, and hope that y'all will consider making the switch. 😊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pycodestyle's rule E713 mandates this, presumably because PEP 8 points out something similar:I happen to agree with this assessment, and hope that y'all will consider making the switch. 😊
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
not inrather thannot ... in.Other Information
Thanks for maintaining! 👍