apply -f: detect binary protobuf payload by content#104
Open
apply -f: detect binary protobuf payload by content#104
Conversation
Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Allow passing protobuf serialized payload in apply -f command
apply -f: detect binary protobuf payload by content
Feb 28, 2026
bcho
requested changes
Feb 28, 2026
Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>
bcho
requested changes
Feb 28, 2026
pkg/cmd/apply/apply.go
Outdated
| // parseActions detects the input format and returns the pre-parsed actions. | ||
| func parseActions(input []byte) ([]parsedAction, error) { | ||
| if isJSONContent(input) { | ||
| tok, err := json.NewDecoder(bytes.NewBuffer(input)).Token() |
Member
There was a problem hiding this comment.
extract this part to a function parseActionFromJSON. Move input parsing implementations to a new file.
Author
There was a problem hiding this comment.
Done in 725bb94. The JSON parsing block is now extracted into parseActionFromJSON and all input parsing implementations (isJSONContent, parseActions, parseActionFromJSON, parseAction, parseActionFromProto) have been moved to the new parse.go file.
Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>
bcho
requested changes
Feb 28, 2026
| _ "github.com/Azure/AKSFlexNode/components/linux" // register linux action types | ||
| ) | ||
|
|
||
| func TestIsJSONContent(t *testing.T) { |
Author
There was a problem hiding this comment.
Done in 494e582. apply_test.go has been renamed to parse_test.go.
Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>
bcho
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isJSONContenthelper — detects JSON by first non-whitespace byte ({/[→ true, binary protobuf → false)parseActionshelper — does detection + parsing, returns[]parsedActionapplynow takes[]parsedActiondirectly (no raw bytes, no format flag)Command.RunEcallsparseActionsbeforeapply(parse then execute)parseActionFromJSONparse.goapply_test.gotoparse_test.goOriginal prompt
apply -fcommand #103💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.