Add E2E test cases for `apply -f` with kubeadm join flow by Copilot · Pull Request #106 · Azure/AKSFlexNode

Copilot · 2026-02-28T05:53:34Z

Original prompt

This section details on the original issue you should resolve

<issue_title>E2E test cases for apply -f usage</issue_title>
<issue_description>We should follow the existing e2e tests under hack/e2e for creating and joining node by using apply -f. We will use kubeadm join flow for this case to fulfill the test coverage for the kubeadm component.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes E2E test cases for apply -f usage #105

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

bcho

@copilot

bcho · 2026-02-28T06:08:56Z

hack/e2e/infra/main.bicep

  }
 }

+resource pipKubeadm 'Microsoft.Network/publicIPAddresses@2023-11-01' = {


do a refactor to make azure vm creation as a reusable bicep module

Refactored in 949e7bc. Extracted pip + NIC + VM into hack/e2e/infra/modules/vm.bicep with an assignManagedIdentity flag. main.bicep now uses three module declarations and references outputs via vmMsi.outputs.principalId etc.

hack/e2e/lib/node-join.sh

bcho · 2026-02-28T06:11:01Z

hack/e2e/lib/node-join.sh

+sudo mkdir -p /etc/aks-flex-node /var/log/aks-flex-node
+sudo cp /tmp/kubeadm-join.json /etc/aks-flex-node/
+
+sudo systemd-run \


don't use systemd-run, just invoke the apply command

Fixed in 949e7bc. The systemd-run wrapper is gone; the remote script now calls sudo /usr/local/bin/aks-flex-node apply --no-prettyui -f /etc/aks-flex-node/kubeadm-join.json directly and tee's output to /var/log/aks-flex-node/aks-flex-node.log.

…rect apply invocation Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

bcho

@copilot

hack/e2e/lib/node-join.sh

bcho · 2026-02-28T06:20:05Z

hack/e2e/infra/modules/vm.bicep

+// =============================================================================
+// modules/vm.bicep - Reusable Ubuntu flex-node VM module
+//
+// Creates a public IP, NIC, and Ubuntu 22.04 VM in the given subnet.


allow customizing the vhd version. Use 24.04 by default

Done in 836de59. Added imagePublisher, imageOffer, imageSku, and imageVersion parameters to modules/vm.bicep. Defaults are now Ubuntu 24.04 LTS (ubuntu-24_04-lts / server / latest). Callers can override any of these to pin a specific image.

…p module Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

bcho · 2026-02-28T06:37:58Z

[06:36:53] [INFO] Checking prerequisites...
[06:36:53] [OK] All prerequisites satisfied
[06:36:53] [INFO] Configuration loaded:
[06:36:53] [INFO]   Resource Group:   ***
[06:36:53] [INFO]   Location:         ***
[06:36:53] [INFO]   Subscription:     ***
[06:36:53] [INFO]   Name Suffix:      1772260613
[06:36:53] [INFO]   Skip Cleanup:     1
==================================================================
  AKS Flex Node E2E Test - Full Run
==================================================================
[06:36:53] [INFO] Building aks-flex-node binary for linux/amd64...
[06:36:56] [OK] Binary built in 3s -> /tmp/aks-flex-node-e2e/aks-flex-node
==================================================================
  Deploying Infrastructure (Bicep)
==================================================================
[06:36:57] [INFO] Resource group already exists: ***
[06:36:57] [INFO] Deploying Bicep template (this may take 5-10 minutes)...
ERROR: /home/github-runner/actions-runner/_work/AKSFlexNode/AKSFlexNode/hack/e2e/infra/main.bicep(191,29) : Error BCP120: This expression is being used in an assignment to the "name" property of the "Microsoft.Authorization/roleAssignments" type, which requires a value that can be calculated at the start of the deployment. Properties of vmMsi which can be calculated at the start include "name". [https://aka.ms/bicep/core-diagnostics#BCP120]
/home/github-runner/actions-runner/_work/AKSFlexNode/AKSFlexNode/hack/e2e/infra/main.bicep(202,29) : Error BCP120: This expression is being used in an assignment to the "name" property of the "Microsoft.Authorization/roleAssignments" type, which requires a value that can be calculated at the start of the deployment. Properties of vmMsi which can be calculated at the start include "name". [https://aka.ms/bicep/core-diagnostics#BCP120]
Error: Process completed with exit code 1.

test failed @copilot

…ent names Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

Copilot · 2026-02-28T06:39:29Z

[06:36:53] [INFO] Checking prerequisites...
[06:36:53] [OK] All prerequisites satisfied

...

Fixed in 9c59f4c. The BCP120 error occurred because the name property of Microsoft.Authorization/roleAssignments was seeded with vmMsi.outputs.principalId, which is a runtime-only module output. Replaced both occurrences with msiVmName (a var known at deployment start) — the principalId is still used correctly in properties.principalId.

bcho

@copilot

bcho · 2026-02-28T06:54:24Z

hack/e2e/lib/node-join.sh

-#   node_join_msi   - Install Azure CLI + MSI auth, deploy binary, run agent
-#   node_join_token - Create bootstrap token/RBAC, deploy binary, run agent
-#   node_join_all   - Join both nodes (MSI first, then token)
+#   node_join_msi      - Install Azure CLI + MSI auth, deploy binary, run agent


split node-join.sh by category into smaller files

Done in eba1003. node-join.sh now only contains the shared _deploy_and_start_agent helper, the three source statements, and node_join_all. Each join mode has its own file:

node-join-msi.sh — node_join_msi

node-join-token.sh — node_join_token

node-join-kubeadm.sh — node_join_kubeadm

run.sh still sources only node-join.sh, so the public API is unchanged.

…in-kubeadm.sh Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

Initial plan

789a6d1

Copilot AI assigned Copilot and bcho Feb 28, 2026

Copilot started work on behalf of bcho February 28, 2026 05:53 View session

Add E2E test cases for apply -f usage with kubeadm join flow

5dd892a

Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add E2E test cases for apply -f usage~~ Add E2E test cases for apply -f with kubeadm join flow Feb 28, 2026

Copilot finished work on behalf of bcho February 28, 2026 06:06

bcho requested changes Feb 28, 2026

View reviewed changes

Copilot started work on behalf of bcho February 28, 2026 06:11 View session

Address review feedback: Bicep module, kubeadm cert-rotation RBAC, di…

949e7bc

…rect apply invocation Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

Copilot finished work on behalf of bcho February 28, 2026 06:18

bcho requested changes Feb 28, 2026

View reviewed changes

Copilot started work on behalf of bcho February 28, 2026 06:21 View session

Add full kubeadm bootstrap config and VHD parameterization in vm.bice…

836de59

…p module Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

Copilot finished work on behalf of bcho February 28, 2026 06:24

Copilot AI had a problem deploying to e2e-testing February 28, 2026 06:26 Error

Copilot AI had a problem deploying to e2e-testing February 28, 2026 06:32 Failure

Copilot started work on behalf of bcho February 28, 2026 06:38 View session

Fix BCP120: use msiVmName var instead of module output in roleAssignm…

9c59f4c

…ent names Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

Copilot finished work on behalf of bcho February 28, 2026 06:39

Copilot AI temporarily deployed to e2e-testing February 28, 2026 06:40 Inactive

bcho requested changes Feb 28, 2026

View reviewed changes

Copilot started work on behalf of bcho February 28, 2026 06:54 View session

Split node-join.sh into node-join-msi.sh, node-join-token.sh, node-jo…

eba1003

…in-kubeadm.sh Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

Copilot finished work on behalf of bcho February 28, 2026 06:59

Copilot AI temporarily deployed to e2e-testing February 28, 2026 18:42 Inactive

bcho marked this pull request as ready for review February 28, 2026 22:23

Conversation

Copilot AI commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments on the Issue (you are @copilot in this section)

Uh oh!

bcho left a comment

Choose a reason for hiding this comment

Uh oh!

bcho Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bcho Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

bcho left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bcho Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

bcho commented Feb 28, 2026

Uh oh!

Copilot AI commented Feb 28, 2026

Uh oh!

bcho left a comment

Choose a reason for hiding this comment

Uh oh!

bcho Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 28, 2026 •

edited

Loading