Skip to content

chore: remove mainred credential provider reviewer#7957

Open
mainred wants to merge 1 commit intomainfrom
mainred/remove-mainred-credential-provider-reviewer
Open

chore: remove mainred credential provider reviewer#7957
mainred wants to merge 1 commit intomainfrom
mainred/remove-mainred-credential-provider-reviewer

Conversation

@mainred
Copy link
Member

@mainred mainred commented Feb 26, 2026

What this PR does / why we need it:

Mainred does not own and maintain credential provider, and should be removed from reviewer list

Which issue(s) this PR fixes:

Fixes #

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the user "mainred" from reviewer lists for credential provider related components in the renovate configuration, as they no longer maintain this component.

Changes:

  • Removed mainred from credential provider reviewer assignments in renovate configuration
  • Updated Linux SIG version to freeze CBL Mariner V2 and Azure Linux V2 at version 202512.06.0
  • Removed unnecessary NVIDIA repository cleanup calls
  • Added disk queue tuning logic and validation
  • Updated authentication method in Azure pipelines and E2E tests
  • Updated component versions in components.json
  • Various pipeline and build process improvements

Reviewed changes

Copilot reviewed 49 out of 318 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/renovate.json Removed mainred from assignees and reviewers for credential-provider-pmc, acr-credential-provider, and azure-cloud-node-manager
pkg/agent/datamodel/sig_config.go Introduced frozen version constant for CBL Mariner V2/Azure Linux V2 and updated all V2 image configs to use it
pkg/agent/datamodel/sig_config_test.go Updated test expectations to use the new frozen version constant
pkg/agent/datamodel/osimageconfig.go Added AzureBleuCloud mapping and reordered entries alphabetically
pkg/agent/datamodel/linux_sig_version.json Updated version from 202511.12.0 to 202512.06.0
parts/linux/cloud-init/artifacts/ubuntu/cse_install_ubuntu.sh Removed call to removeNvidiaRepos from cleanUpGPUDrivers function
parts/linux/cloud-init/artifacts/ubuntu/cse_helpers_ubuntu.sh Added apt-get clean after successful package installation
parts/linux/cloud-init/artifacts/mariner/cse_install_mariner.sh Removed call to removeNvidiaRepos from cleanUpGPUDrivers function
parts/linux/cloud-init/artifacts/disk_queue.sh New script implementing disk queue tuning logic with NVMe detection
parts/linux/cloud-init/artifacts/disk_queue.service Updated to use the new disk_queue.sh script instead of hardcoded sda commands
parts/linux/cloud-init/artifacts/cse_config.sh Removed NVIDIA repository cleanup from configGPUDrivers function
parts/common/components.json Updated various component versions including Windows servercore, kube-proxy, kubelet, kubectl, and other images
packer.mk Removed az-login target implementation, moving authentication to pipeline level
e2e/validators.go Added new validation functions for AKS log collector and disk queue service
e2e/validation.go Refactored to use new validator functions
e2e/scenario_test.go Updated secure TLS bootstrapping test to use UserAssignedIdentityID instead of AADResource
e2e/config/azure.go Changed credential type from DefaultAzureCredential to AzureCLICredential
.pipelines/templates/e2e-template.yaml Wrapped e2e commands in AzureCLI tasks
.pipelines/templates/.builder-release-template.yaml Wrapped all packer/make commands in AzureCLI tasks
.pipelines/templates/.builder-release-template-windows.yaml Wrapped Windows VHD build commands in AzureCLI tasks and removed direct az login calls
.pipelines/templates/.build-and-test-windows-vhds-template.yaml Wrapped cleanup script in AzureCLI task
.pipelines/scripts/windows_build_vhd.sh Removed az-login make target call
.pipelines/scripts/windows-sub-cleanup.sh Removed az-login make target call
.pipelines/scripts/e2e_run.sh Removed manual az login using managed identity
.pipelines/.vsts-vhd-builder-release.yaml Changed default build flags for Mariner V2 and Azure Linux V2 variants to false
.pipelines/.vsts-vhd-builder-pr-windows.yaml Wrapped cleanup script in AzureCLI task
.pipelines/.vsts-garabge-collection.yaml Wrapped garbage collection script in AzureCLI task
.github/workflows/pr-lint.yaml Added 'synchronize' trigger type for PR linting
pkg/agent/testdata/AKSUbuntu2204+CustomCloud/CustomData Regenerated test snapshot data reflecting version and component updates
pkg/agent/testdata/AKSUbuntu2204+China/CustomData Regenerated test snapshot data reflecting version and component updates
Comments suppressed due to low confidence (4)

pkg/agent/datamodel/osimageconfig.go:18

  • Cloud name contains typo: 'AzureBleuCloud' should likely be 'AzureBlueCloud' (unless this is an intentional non-English reference).
		AzureBleuCloud: {
			AKSUbuntuContainerd2204Gen2: AKSUbuntuContainerd2204Gen2OSImageConfig,
		},

pkg/agent/datamodel/osimageconfig.go:18

  • The addition of AzureBleuCloud mapping lacks test coverage. Consider adding a test case to verify this cloud configuration is properly recognized and mapped.
		AzureBleuCloud: {
			AKSUbuntuContainerd2204Gen2: AKSUbuntuContainerd2204Gen2OSImageConfig,
		},

parts/linux/cloud-init/artifacts/disk_queue.sh:14

  • Error message at line 12 should be capitalized for consistency with shell script conventions: 'No root or os device link found...'
if [ -L "/dev/disk/azure/root" ]; then
    LINK_PATH="/dev/disk/azure/root"
elif [ -L "/dev/disk/azure/os" ]; then
    LINK_PATH="/dev/disk/azure/os"
else
    echo "no root or os device link found within /dev/disk/azure, cannot apply disk tuning"
    exit 1
fi

parts/linux/cloud-init/artifacts/disk_queue.sh:26

  • The script exits with code 0 for NVMe devices (line 27), which indicates success even though tuning wasn't applied. Consider logging at a different level or returning a distinct exit code to help distinguish between 'successfully applied' vs 'skipped because NVMe' in systemd service monitoring.
    echo "$DEV_NAME is an NVMe device, will not apply disk tuning"

@mainred mainred force-pushed the mainred/remove-mainred-credential-provider-reviewer branch from 52bae6a to 53d58dc Compare February 26, 2026 00:48
@mainred
Copy link
Member Author

mainred commented Feb 26, 2026

cc @cameronmeissner @nilo19

@mainred mainred changed the title Mainred/remove mainred credential provider reviewer chore: remove mainred credential provider reviewer Feb 26, 2026
@awesomenix
Copy link
Contributor

You need to sign your commits

@mainred mainred force-pushed the mainred/remove-mainred-credential-provider-reviewer branch from 53d58dc to 6466400 Compare February 26, 2026 04:36
@mainred
Copy link
Member Author

mainred commented Feb 26, 2026

You need to sign your commits

@awesomenix Done

@mainred mainred enabled auto-merge (squash) February 26, 2026 04:37
Copy link
Contributor

@cameronmeissner cameronmeissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mainred still looks like your commits are unverified

Signed-off-by: Qingchuan Hao <qingchuan.hao@microsoft.com>
@mainred mainred force-pushed the mainred/remove-mainred-credential-provider-reviewer branch from 6466400 to f52588f Compare March 2, 2026 01:32
@mainred
Copy link
Member Author

mainred commented Mar 2, 2026

@cameronmeissner should be good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants