feat: windows cse ensure oras and reserve some exit code for network isolated cluster#7995
Open
feat: windows cse ensure oras and reserve some exit code for network isolated cluster#7995
Conversation
fseldow
requested review from
AbelHu,
Devinwong,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
fseldow
changed the title
fseldow
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds initial ORAS bootstrap support for network-isolated Windows clusters and reserves dedicated exit codes to classify ORAS-related failures.
Changes:
- Introduces
Ensure-Orasto install ORAS from a cached archive on Windows nodes. - Reserves/records new ORAS-related Windows CSE exit codes and registers them in
ErrorCodeNames. - Wires ORAS bootstrapping into
BasePrepwhen a bootstrap profile registry server is configured, and adds Pester coverage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| parts/windows/windowscsehelper.tests.ps1 | Adds Pester tests covering Ensure-Oras success and failure paths. |
| parts/windows/windowscsehelper.ps1 | Adds ORAS-related exit codes and implements Ensure-Oras. |
| parts/windows/kuberneteswindowssetup.ps1 | Defines ORAS globals for network-isolated clusters and calls Ensure-Oras during base prep. |
timmy-wright
reviewed
Mar 2, 2026
timmy-wright
requested changes
Mar 2, 2026
Contributor
timmy-wright
left a comment
timmy-wright
left a comment
There was a problem hiding this comment.
Windows uses the latest CSE script on all VHDs - unlike Linux where we match the AgentBakerSvc version and the VHD version. As older Windows VHDs won't have oras installed on them, the function "Ensure-Oras" will mean that all older windows VHDs will be unable to join clusters. Which is not really an IcM I want to have to deal with.
timmy-wright
reviewed
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
init oras and reserve some exit code for network isolated cluster
Which issue(s) this PR fixes:
Fixes #