Fixes Azurite V3 emulator not returning 412 Precondition Failed if a resource (blob) does not exist and "*" IfMatch is provided. #2621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasoncheungg
changed the title
jasoncheungg
changed the title
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
blueww
reviewed
Jan 6, 2026
| throw StorageErrorFactory.getConditionNotMet(context.contextId!); | ||
| } | ||
| return; | ||
| // Throw if there is any value in if-match for non exist blob |
Member
There was a problem hiding this comment.
Could you validate all the write request call this function on real azure server will have this behavior?
If so, this change is OK.
Else, you might need to so some check for the API here.
Others are all good for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where the Azurite V3 emulator does not return 412 Precondition Failed if a resource (blob) does not exist and "*" IfMatch is provided.
Issue #2589