Merged
Conversation
catalinaperalta
requested review from
iscai-msft,
msyyc and
tadelesh
as code owners
iscai-msft
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The black plugin was causing the python emitter to take over 2-4 minutes to run in some cases. For example, when using the python emitter with tsp-client folks frequently run into this issue. Removed the black plugin and moved that logic directly into the emitter. With these updates the emitter takes about 15 seconds to run. ~90% improvement in perf which will be a noticeable improvement for python emitter users.
Related PR: microsoft/typespec#6979