Skip to content

[pipeline] remove delete logic before regeneration #3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iscai-msft merged 1 commit into from
Jul 28, 2025
Merged

[pipeline] remove delete logic before regeneration #3141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions eng/pipelines/ci-template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,7 @@ steps:
workingDirectory: $(Build.SourcesDirectory)/autorest.python/packages/${{parameters.folderName}}/
condition: and(succeeded(), ${{ parameters.regenerate }}, eq('${{parameters.folderName}}', 'autorest.python'))

- script: |
rm -rf test/azure/generated test/unbranded/generated
npm run regenerate
- script: npm run regenerate
Copy link
Member Author

@msyyc msyyc Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another solution is that we add --filter for those directory which has patched code. But this solution may need additional maintenance if we plan to add more patch code in the future.
@iscai-msft which one do you prefer?

Copy link
Member

@tadelesh tadelesh Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Go, we put some keywords like DO NOT EDIT for the generated code. I think Python could follow the similar logic. Only remove the auto-generated code.

Copy link
Contributor

@iscai-msft iscai-msft Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we could do something like that, let me create an issue for that. For the meantime, this is good, thanks!

displayName: "Regenerate Code(typespec)"
workingDirectory: $(Build.SourcesDirectory)/autorest.python/packages/${{parameters.folderName}}/
condition: and(succeeded(), ${{ parameters.regenerate }}, eq('${{parameters.folderName}}', 'typespec-python'))
Expand Down
Loading