Add API to add an IpSecurityRestriction while Defining a WebApp#548
Open
dpetillo wants to merge 4 commits intoAzure:masterfrom
Open
Add API to add an IpSecurityRestriction while Defining a WebApp#548dpetillo wants to merge 4 commits intoAzure:masterfrom
dpetillo wants to merge 4 commits intoAzure:masterfrom
Conversation
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
@azuresdkci test this please. |
praries880
reviewed
Apr 29, 2019
| /// </summary> | ||
| /// <param name="ipAddress">IP address the security restriction is | ||
| /// valid for.</param> | ||
| /// valid for. |
Contributor
There was a problem hiding this comment.
@dpetillo
you can undo these changes, The model got updated with these properties added to it :
Contributor
|
@dpetillo We have already updated the models to include the changes you have here. We still need to add a public API to make IPSecurityRestriction available on the Fluent API though. We will get try to get the suggestions here in webapps in the near future. The API changes you made do look good, but we still have to look into the update (PATCH) scenario and add tests for the same. |
|
@ChenTanyi please follow with this PR. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed this functionality added to the API. If it can be added to master, I think ill need advisement on my API signature(s) and how to properly regenerate the model:
src\ResourceManagement\AppService\Generated\Models\IpSecurityRestriction.cs
The copy in this commit was taken from https://github.com/Azure/azure-sdk-for-net and lightly modified.