Refactor SearchableDropdown with Fluent UI components, extract styles, and add tests#2329
Conversation
|
@copilot
|
- Replace native HTML elements with Fluent UI components (Stack, DefaultButton, Text) - Extract inline styles to SearchableDropdown.styles.ts - Add comprehensive unit tests (14 test cases) - Verify behavior consistency with AccountSwitcher tests Co-authored-by: nishthaAhujaa <45535788+nishthaAhujaa@users.noreply.github.com>
Co-authored-by: nishthaAhujaa <45535788+nishthaAhujaa@users.noreply.github.com>
All review feedback has been addressed in commits 302b13a and eb2c560: ✅ Fluent UI components: Replaced native HTML elements with Stack, DefaultButton, and Text components The SearchableDropdown component now follows Fluent UI design patterns and has full test coverage while maintaining backward compatibility with SwitchAccount and SwitchSubscription components. |
|
@copilot it looks like the UI looks different than the previous pr can you make the Ui similar only like the placeholder texts and selected texts were left aligned not anymore |
- Add flexContainer.justifyContent: "flex-start" to button styles - Add textAlign: "left" to button label, item styles, and empty message - Restore original left-aligned appearance for placeholder and selected text Co-authored-by: nishthaAhujaa <45535788+nishthaAhujaa@users.noreply.github.com>
Fixed text alignment in commit 0c5a0e0. The placeholder and selected text are now left-aligned as in the original UI. Changes made:
All tests still passing (14/14 SearchableDropdown tests, 2/2 AccountSwitcher tests). |
f7d3dc1
into
users/nishthaahuja/searchableDropdown
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.