DDM login issue fixed while logging in via connection string#2353
Merged
sakshigupta12feb merged 4 commits intomasterfrom Feb 2, 2026
Merged
DDM login issue fixed while logging in via connection string#2353sakshigupta12feb merged 4 commits intomasterfrom
sakshigupta12feb merged 4 commits intomasterfrom
Conversation
Collaborator
Author
|
@copilot Review this PR |
Contributor
|
@sakshigupta12feb I've opened a new pull request, #2354, to work on those changes. Once the pull request is ready, I'll request review from you. |
sunghyunkang1111
previously approved these changes
Jan 27, 2026
…nd, if present, must be an array
nishthaAhujaa
previously approved these changes
Jan 28, 2026
sunghyunkang1111
approved these changes
Jan 29, 2026
jawelton74
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview this branch
When logging in with a connection string, the DDM tab was not visible. If a DDM policy is set up (not just the feature enabled) and users log in using a connection string, the tab will appear.
Removed the key "isPolicyEnabled". In the backend, its value will instead be determined by the "includedPaths" field. If its empty then isPolicyEnabled will be false and true if non empty.
we need to add a validation for the field "includePaths". It should be present and should be an array only. It could be an empty array.
The field "excludedPaths" will be optional.