Fix: use retry.RetryOnConflict to prevent retry storm on composition status updates#574
Open
hunter32292 wants to merge 2 commits intomainfrom
Open
Fix: use retry.RetryOnConflict to prevent retry storm on composition status updates#574hunter32292 wants to merge 2 commits intomainfrom
hunter32292 wants to merge 2 commits intomainfrom
Conversation
…status updates When multiple controllers concurrently update composition status, conflict errors cause immediate requeues without backoff, leading to a retry storm that can overwhelm the API server (142+ retries/second observed). This fix uses k8s.io/client-go/util/retry.RetryOnConflict which: - Re-fetches the composition before each retry attempt - Applies exponential backoff between retries - Handles conflicts internally instead of propagating errors This prevents the thundering herd effect where conflict errors cascade through the controller-runtime work queue. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…he concurrent status updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple controllers concurrently update composition status, conflict
errors cause immediate requeues without backoff, leading to a retry storm
that can overwhelm the API server (142+ retries/second observed).
This fix uses k8s.io/client-go/util/retry.RetryOnConflict which:
This prevents the thundering herd effect where conflict errors cascade
through the controller-runtime work queue.