Add aks-rest module and apply to hyperscale pipelines

[liyu-ma]

• Add aks-rest module to allow calling AKS in restful api
• Update hyperscale pipelines to provision cluster with aks-rest

[Copilot]

Pull request overview

Adds a new Terraform submodule to provision AKS clusters via ARM REST (az rest) so hyperscale tiers can use REST-only features (e.g., controlPlaneScalingProfile), and updates hyperscale provisioning inputs/pipelines to use it.

Changes:

• Introduce aks_rest_config_list to the Azure Terraform module and wire in a new aks-rest submodule driven by az rest.
• Switch CCP hyperscale tfvars (H2/H4/H8) from aks_cli_config_list to aks_rest_config_list with control-plane scaling settings.
• Update hyperscale validation/test pipeline inputs (regions, expected H2 cores, and add Terraform tests for the new module).

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
steps/topology/hyperscale-cluster/validate-resources.yml	Adjust expected GOMAXPROCS cores for H2 tier.
scenarios/perf-eval/ccp-provisioning/terraform-test-inputs/azure-H4.json	Change test region to westus2.
scenarios/perf-eval/ccp-provisioning/terraform-test-inputs/azure-H8.json	Change test region to westus2.
scenarios/perf-eval/ccp-provisioning/terraform-inputs/azure-H2.tfvars	Move hyperscale provisioning to aks_rest_config_list and set control-plane scaling/profile inputs.
scenarios/perf-eval/ccp-provisioning/terraform-inputs/azure-H4.tfvars	Same as H2 for H4 tier.
scenarios/perf-eval/ccp-provisioning/terraform-inputs/azure-H8.tfvars	Same as H2 for H8 tier.
pipelines/system/new-pipeline-test.yml	Replace placeholders with a concrete example pipeline configuration.
modules/terraform/azure/variables.tf	Add aks_rest_config_list variable schema.
modules/terraform/azure/main.tf	Merge json_input overrides into aks_rest_config_list and instantiate module "aks-rest".
modules/terraform/azure/aks-rest/variables.tf	Define inputs for the new aks-rest module (REST provisioning).
modules/terraform/azure/aks-rest/main.tf	Implement REST request body + local-exec provisioning/deletion commands and supporting role assignments.
modules/terraform/azure/aks-rest/output.tf	Expose generated commands/request body for tests/debugging.
modules/terraform/azure/tests/test_aks_rest.tftest.hcl	Add terraform test coverage validating command composition and request body content.

[vittoriasalim]

I suggest to simplfiy this to aks cli module this way you do not need to create a new module for aks-rest or added new variables for every parameters

see this example

telescope/modules/terraform/azure/aks-cli/main.tf

Line 155 in 901203f

aks_cli_command = join(" ", concat([

telescope/modules/terraform/azure/main.tf

Line 52 in 901203f

updated_aks_cli_config_list = length(var.aks_cli_config_list) > 0 ? [

[liyu-ma]

Hmm I feel it is cleaner to have a separate module. Essentially they are different commands so the format of the parameters vary from each other. Yes the parameters list will be the same or similar if they are doing the same thing e.g. create cluster, but from code maintenance perspective they could evolve differently in future. Not sure if this makes sense?

[vittoriasalim]

For background , there are 2 ways to create kubernetes resources, first by aks-cli and second by terraform https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/kubernetes_cluster

aks-cli, these will contain commands for

1. az aks create
2. az aks delete
3. az aks add nodepool
4. az aks delete nodepool
5. (if we need to support az rest , we simply add a new command in this module)

Second for the terraform way it will call terraform module create , delete, add nodepool (e.g)
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/kubernetes_cluster
So my question is what is the strong reason, we need new module for kubernetes resources, when az aks rest only need 3 flags (url, header, body)

The limitation of your implementation you make the body of the rest as each value paramaters, which is hard to extend and maintain . I suggest to use this draft example https://github.com/Azure/telescope/pull/1080/changes

[xinWeiWei24]

For az rest, we can use a Terraform module instead of using command line
https://registry.terraform.io/providers/Azure/azapi/latest/docs/resources/resourc

[vittoriasalim]

We need to update both module, aks cli and aks terraform.
Since liyu already using aks cli in this PR and has the the core logic with aks cli in [here] (

telescope/modules/terraform/azure/aks-rest/main.tf

Line 138 in 803df62

az_rest_put_command = join(" && ", compact([

), we can use aks-cli first and add aks rest support to terraform in the next PR. It is faster to unblock than refactor the change to terraform right now

[xinWeiWei24]

I think it would be better to move the pipeline and scenario changes to the next PR.