Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #16.
After PR #14, the image gained metadata: sector size, superblock, and bitmap numbers. This is because images can vary greatly depending on their source: from a hard drive, bubble memory, or floppy disks (which also differ).
The next logical step would be to combine the metadata and the disk image into a single structure. This significantly simplifies the API and reduces the chance of mixing up metadata and the images from different sources.
This PR removes
ccos_context_tand migrates the entire API to theccos_disk_tstructure, updating the doxygen comments for the changed functions. Nothing else changes. Function names remain the same, and there are no functional changes.