Skip to content

test: remove deprecated MT_RAND_PHP and fix mt_rand() upper bound #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DASPRiD merged 1 commit into from
Nov 16, 2025
Merged

test: remove deprecated MT_RAND_PHP and fix mt_rand() upper bound #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/Common/BitArrayTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public function testGetNextSet4() : void

public function testGetNextSet5() : void
{
mt_srand(0xdeadbeef, MT_RAND_PHP);
mt_srand(0xdeadbeef);

for ($i = 0; $i < 10; ++$i) {
$array = new BitArray(mt_rand(1, 100));
Expand Down
4 changes: 2 additions & 2 deletions test/Common/ReedSolomonCodecTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public static function tabs() : array
#[DataProvider('tabs')]
public function testCodec(int $symbolSize, int $generatorPoly, int $firstRoot, int $primitive, int $numRoots) : void
{
mt_srand(0xdeadbeef, MT_RAND_PHP);
mt_srand(0xdeadbeef);

$blockSize = (1 << $symbolSize) - 1;
$dataSize = $blockSize - $numRoots;
Expand Down Expand Up @@ -60,7 +60,7 @@ public function testCodec(int $symbolSize, int $generatorPoly, int $firstRoot, i
$errorValue = mt_rand(1, $blockSize);

do {
$errorLocation = mt_rand(0, $blockSize);
$errorLocation = mt_rand(0, $blockSize - 1);
} while (0 !== $errorLocations[$errorLocation]);

$errorLocations[$errorLocation] = 1;
Expand Down