This repository was archived by the owner on Jun 17, 2025. It is now read-only.
skip chains with no fees/core pools#327
Merged
gosuto-inzasheru merged 4 commits intomainfrom Jan 16, 2025
Merged
Conversation
Collaborator
Author
Xeonus
approved these changes
Jan 16, 2025
Contributor
Xeonus
left a comment
Xeonus
left a comment
There was a problem hiding this comment.
- fixes issues if there were no fees collected
- skips if core pool list is empty for target chain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will skip chains defined in the Chains enum if there are no fees so zkevm doesnt have to be manually toggled. also handled edge case where a chain has fees but no core pools to distribute them to that would cause recon to fail